[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] svnversion should output its help messages to stdout (Take 2)

From: Kobayashi Noritada <nori1_at_dolphin.c.u-tokyo.ac.jp>
Date: 2005-02-23 18:03:00 CET

Hi,

> +1 with that change.

Thanks for your review and approval.
I fixed the exit status and committed it at r13128.

> exit(0), since displaying the help is now by request and no longer an error.

BTW 'svnserve -h', which I referred in writing a patch, seems to exit
with the status code '1' although it outputs the help message as expected:

    svn_error_clear (svn_cmdline_fprintf(stdout, pool, "\n"));
    exit(1);
  }

This bothered me.
Is this a mistake and shall I fix it?
Or is there a reason that should exit at '1'?

Thanks,

-- 
|:  Noritada KOBAYASHI
|:  Dept. of General Systems Studies,
|:  Graduate School of Arts and Sciences, Univ. of Tokyo
|:  E-mail: nori1@dolphin.c.u-tokyo.ac.jp (preferable)
|:          nori@esa.c.u-tokyo.ac.jp
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Feb 23 18:04:10 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.