[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r13123 - in trunk/subversion: clients/cmdline include libsvn_client

From: John Szakmeister <john_at_szakmeister.net>
Date: 2005-02-23 04:30:26 CET

On Tuesday 22 February 2005 18:21, sussman@tigris.org wrote:
> Author: sussman
[snip]
> - /* Note: we have to be paranoid about checking that these are
> - valid, since svn_wc_entry() doesn't fill them in if they
> - aren't in the entries file. */
> -
> - if (entry->name && strcmp (entry->name, SVN_WC_ENTRY_THIS_DIR))
> - SVN_ERR (svn_cmdline_printf (pool, _("Name: %s\n"), entry->name));
> + /* ### remove this someday: it's only here for cmdline output
> + compatibility with svn 1.1 and older. */
> + SVN_ERR (svn_cmdline_printf (pool, _("Name: %s\n"),
> + svn_path_basename(target, pool)));

This change broke switch tests 11 and 13 (at least on my build). In these
2 test cases, svn info was being run on a directory, and hence, the
entry->name was "". Therefore, the "Name:" was never printed before.
With this change, it's always printing the "Name:" line.

The attached patch works against ra_local. I haven't tested it against
the other layers.

-John

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Wed Feb 23 05:49:40 2005

This is an archived mail posted to the Subversion Dev mailing list.