[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r13112 - in trunk/subversion: libsvn_fs_base libsvn_subr

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2005-02-22 22:00:39 CET

"Erik Huelsmann" <e.huelsmann@gmx.net> writes:

>> While I would agree that one line error messages are generally better,
>> I think this one might be an exception. Is there any particular
>> reason to avoid "\n", i18n perhaps?
>
> Our i18n code compensates for the problem that some platforms use CRLF, so
> that's not really the reason. \n characters don't go well with GUI and other
> applications which don't have 80 character wide displays.

I suppose I prefer the error string with \n characters, but it's
marginal and I don't mind if it changes. What I do care about is that
the comment and the code match, and at present they don't, so you
should change one or the other.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Feb 22 22:02:30 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.