Re: State of vc-svn.el

"Eric S. Raymond" <esr@snark.thyrsus.com> wrote:

> Some months ago one of the listmembers here who was aware that I am
> the original author of Emacs VC mode asked me to review the vc-svn.el
> written by Jim Blandy that ships with Subversion.
>
> I have not forgotten this request, and it just worked its way far
> enough up my queue to get some action. I have looked at both the
> Blandy version and the version by Stefan Monnier that now ships with
> Emacs.

This is really good news. :-)

I posted a small patch to vc-svn-checkout that adds destfile support
so that C-x v ~ and ediff both work properly. I hope you'll either
consider accepting that patch or fixing it in the right way if I got
it wrong. You can find my original message in the list archives
sometime in the past week or so or else look at issue 2225. The
current vc-svn-checkout could raises an error if editable is nil. My
patch changes it to ignore editable if destfile is given, but
otherwise, it still raises an error. It would probably be better for
it to simply ignore this flag or else to make the resulting file or
buffer read only.

There are two other issues with vc-svn.el that I was going to try to
fix and send patches for:

 * annotate (C-x v g) isn't currently supported even though svn blame
   exists

 * if you use vc-register to register a file that is neither in a
   subversion working copy, in a CVS sandbox, or in a directory that
   contains RCS, you get an error:

   apply: Error running Subversion to add `a'

   If vc-svn.el is not present, it just defaults to checking in the
   file with RCS, which is more sensible. Anyway, I'm not sure what
   the right behavior is, but getting an error from vc-svn.el isn't
   it. :-) I'm sure this would be easy to fix. It's probably as
   simple as implementing vc-svn-responsible-p and
   vc-svn-could-register.

If you'd like me to work on either of these, let me know. I was
probably going to take a crack at both this weekend, but if you're
going to be working on the code, maybe I don't need to.

-- 
Jay Berkenbilt <ejb@ql.org>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org