[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [patch] Issue #601 regression tests in trans_tests.py

From: Madan U Sreenivasan <madan_at_collab.net>
Date: 2005-02-18 06:24:57 CET

kfogel@collab.net wrote:

>Philip Martin <philip@codematters.co.uk> writes:
>
>
>>Madan U Sreenivasan <madan@collab.net> writes:
>>
>>
>>
>>>+#----------------------------------------------------------------------
>>>+# Regression test described in issue #601.
>>>+# Add the keyword property to a file, svn revert the file, see
>>>+# error.
>>>+def propset_revert(sbox):
>>>+ "propset, revert"
>>>+
>>>+ sbox.build()
>>>+ wc_dir = sbox.wc_dir
>>>+ mu_path = os.path.join(wc_dir, 'A', 'mu')
>>>+
>>>+ # Set the Rev keyword for the mu file
>>>+ svntest.actions.run_and_verify_svn(None, None, [],
>>>+ 'propset', 'svn:keywords', 'Rev', mu_path)
>>>+
>>>+ # Revert the propset
>>>+ svntest.actions.run_and_verify_svn(None, None, [], 'revert', mu_path)
>>>
>>>
>>As written it's a bit of a weak test, I'd prefer to see a call to
>>run_and_verify_status after the propset and another one after the
>>revert, that would provide a stronger guarantee that the revert is
>>making a change. You could also check the revert output message.
>>
>>
>
>Madan, want to write a patch against the test as committed in r13027?
>
>(I agree with Philip's comments; I should have said the same thing
>myself when I reviewed it in fact.)
>
>-Karl
>
>

Sure, Karl.... thanks for the inputs, Philip.
> btw, Karl... the below is from the comments removed in r13027
>
> -# 1. Ben encountered this:
> -# Create a greek tree, commit a keyword into one file,
> -# then commit a keyword property (i.e., turn on keywords), then
> -# try to check out head somewhere else. See seg fault.
>
> I wanted to use try: .... except OSError:... for this. But this has
> not gone into r13027... I think the last line of the above comment
> would need to use the try...except block. What do you think?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Feb 18 06:19:03 2005

This is an archived mail posted to the Subversion Dev mailing list.