> From: kfogel@newton.ch.collab.net
>
> Charles Bailey <bailey@newman.upenn.edu> writes:
> > Two quick questions:
> > - Is it worth a small patch to xml.c to include the contents of the
> > offending buffer in a "Malformed XML" error message? It
> could yield a
> > long/multiline message, but would help identify the
> offending text in
> > a large operation.
>
> Hmmm. That's tough. How big can the buffer get? (It would do us no
> good to just display part of it, since we don't know where the problem
> characters would be.) We could have a heuristic that we display the
> buffer if it's below a certain size, and don't if it's above.
It would seem to me that if svn was to generate "Malformed XML" messages, it
should do so like a good compiler generates messages, mentioning fairly
narrowly the nature of the violation, the file (or whatever) within which
the violation was found, and the line/character offset at which the
violation was found. If it is dynamically created XML passed by the server
or some such, svn should save it into a file, and tell the user the name of
the file (as is now done with commit messages upon failed commits), so the
user can attach it to the bug report.
Yeah, that's more than a bit of work, but good error reporting takes work,
and is almost always worth it.
Dale
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Feb 17 15:40:33 2005