Re: [patch] Issue #601 regression tests in trans_tests.py

Madan U Sreenivasan <madan@collab.net> writes:

> +#----------------------------------------------------------------------
> +# Regression test described in issue #601.
> +# Add the keyword property to a file, svn revert the file, see
> +# error.
> +def propset_revert(sbox):
> + "propset, revert"
> +
> + sbox.build()
> + wc_dir = sbox.wc_dir
> + mu_path = os.path.join(wc_dir, 'A', 'mu')
> +
> + # Set the Rev keyword for the mu file
> + svntest.actions.run_and_verify_svn(None, None, [],
> + 'propset', 'svn:keywords', 'Rev', mu_path)
> +
> + # Revert the propset
> + svntest.actions.run_and_verify_svn(None, None, [], 'revert', mu_path)

As written it's a bit of a weak test, I'd prefer to see a call to
run_and_verify_status after the propset and another one after the
revert, that would provide a stronger guarantee that the revert is
making a change. You could also check the revert output message.

> +
> ########################################################################
> # Run the tests
>
> @@ -668,6 +730,8 @@
> keyword_expanded_on_checkout,
> cat_keyword_expansion,
> copy_propset_commit,
> + propset_commit_otherwc_checkout,
> + propset_revert,
> ]

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org