[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r12988 - in trunk: build/generator subversion/libsvn_fs_base subversion/libsvn_fs_base/bdb

From: <kfogel_at_collab.net>
Date: 2005-02-14 15:50:41 CET

brane@tigris.org writes:
> --- trunk/subversion/libsvn_fs_base/fs.c (original)
> +++ trunk/subversion/libsvn_fs_base/fs.c Sat Feb 12 13:44:09 2005
> @@ -336,7 +335,8 @@
> if (!db_err)
> {
> (*envp)->set_errpfx (*envp, (char *) (*ec_batonp));
> - (*envp)->set_errcall (*envp, bdb_error_gatherer);
> + /* ### bdb_error_gatherer is in params to stop macro expansion. */
> + (*envp)->set_errcall (*envp, (bdb_error_gatherer));
>
> /* Needed on Windows in case Subversion and Berkeley DB are using
> different C runtime libraries */

In that comment, I assume you meant "parens" instead of "params"?
And, the "###" that starts the comment implies that this is a FIXME
(at least, that's the convention we've been using). So either the
comment should indicate what the right way to do things would be, or
the three hash marks should go away.

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Feb 14 16:07:11 2005

This is an archived mail posted to the Subversion Dev mailing list.