[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r12919 - in trunk/subversion: include libsvn_subr mod_dav_svn tests/clients/cmdline

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2005-02-10 05:04:37 CET

Branko Čibej wrote:
> kfogel@tigris.org wrote:
>> + if (svn_ctype_iscntrl (*q)
>> + && ! ((*q == '\n') || (*q == '\r') || (*q == '\t')))
>>
> These are UTF-8 strings, so you should define character value constants
> in svn_ctype.h and use them here.

Are you sure that we should? I believe we use "\n" etc. all over the place in
UTF-8 strings. It would only be wrong in a non-ASCII-compatible system, and
the only one that I have heard of Subversion being ported to is an EBCDIC one
that was discussed on the list and presumably has a satisfactory way of
handling this.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Feb 10 05:06:01 2005

This is an archived mail posted to the Subversion Dev mailing list.