[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Re: "Revision" case-sensitive in svn:keywords

From: Max Bowsher <maxb_at_ukf.net>
Date: 2005-02-07 21:49:55 CET

Peter N. Lundblad wrote:
> On Mon, 7 Feb 2005, Max Bowsher wrote:
>
>> Wesley J. Landaker wrote:
>>> On Thu, 27 Jan 2005, Felix Wiemann wrote:
>>>> The word "revision" is not recognized in svn:keywords, but "Revision"
>>>> is. IMO it should be matched case-insensitively for consistency with
>>>> 'Author' or 'Date', shouldn't it?
>>>
>>> This seems like a good idea, since all the other "SHORT" forms are
>>> handled
>>> thus (and this is the only "MEDIUM" one). Here is a patch if the
>>> developer's agree as well. =)
>>>
>>> Log Message:
>>> * libsvn_subr/subst.c
>>> (svn_subst_build_keywords): Make "Revision" keyword case insensitve.
>>
>>
>> If no one objects, I'm going to apply this.
>
> Is there some special reason some keywords are case-sensitive, but other
> are not?

Not to my knowledge.

Personally, I'd prefer that svn:keywords was entirely case-sensitive, just
like the actual substitutions. However, it's a bit late for that now.

The scheme seems to be LONG == case-sensitive, SHORT == case-insensitive.
Since "Revision", whilst being MEDIUM and thus a grey area, is similar to
"Date", "Author", etc., i.e. the SHORT keywords, I think it should follow
their pattern, and be case-insensitive.

Max.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Feb 7 21:55:14 2005

This is an archived mail posted to the Subversion Dev mailing list.