Re: Issue #1559 - Windows Service needed server side for svnserve

On Wednesday 02 February 2005 16.50, Max Bowsher wrote:
...
> > This is what I'll do:
> >
> > * Include Magnus Norddahl's SVN Service Wrapper for Windows
> > (SVNService) with the installer.
>
> I would suggest that SVNService should go into contrib/, be built as
> part of the standard Windows build, and then be built into the
> installer from there, rather than be an installer-only thing.

Good idea, but I'm not sure that the contents of SVNService.zip is public
domain enought (however, I think the binary is safe).

A Microsoft copyright notice occurs (C 1993-1997)in the heading of
service.h. and service.c (wich is a modified MS file). Is service.c
something we are aloved to have in the contrib area? service.h should
not be any problem, it's a VC compiler related include file if I recall
right.

Three more things:
1) The binary in the zip file probably have to go elswhere because
binaries should not be in the repository - and I don't want diffrent
versions of a binary compiled from one source. It can be placed in the
same place as the svnpath binary (which will be obsolete soon, Inno
Setup will do it 100%) wich is currently:

  http://subversion.tigris.org/servlets/ProjectDocumentList?folderID=2728

This directory is actually named "Development snapshots of Windows
binaries".

2) Is it enough to just include the following files in the contrib area
(or are all the files in SVNService.zip needed)?

  log_messages.h
  log_messages.rc
  resource.h
  service.c
  SVNService.dsp
  SVNService.dsw
  SVNService.ico
  SVNService.rc

  ...and exclude the following ones?
  MSG00001.bin
  log_messages.mc
  service.h

3) Would 'contrib/win-svnservice' be ok in the trunk?

Jostein

-- 
http://www.josander.net/en/contact/