Mark Therieau wrote:
> Norbert Unterberg <nepo <at> gmx.net> writes:
>> There remains an issue with the DIFFs. I have setup a diff.exe from the
>> GnuWin32 tools which works with the command line from
>> mailer.conf.example. The diffs are added to the commit mails.
>> BUT: Each line from the diff contains an extra CRLF pair.
>
> I saw the same extra lines in the emailed diffs. I don't know if this is
> the correct fix or not, but changing the popen2/popen4 modes to text
> instead of binary worked for me...
I'm rather confused.
Are you using sendmail or SMTP output mode?
I assume SMTP, since that would be far easier on Windows.
The strange thing is that the Python smtplib normalizes newlines. So, I
don't see how the weirdness you describe could occur, unless the GnuWin32
diff.exe was emitting bizarre newline combinations.
Could either of you add "print repr(self.buffer.getvalue())" to the end of
SMTPOutput.finish, to see what the newlines look like at this stage?
Max.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jan 28 17:56:48 2005