[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Crash in svn_client_ls()

From: SteveKing <steveking_at_gmx.ch>
Date: 2005-01-26 19:57:19 CET


Going through all crashreports I received for TortoiseSVN the last week,
I found the following which is something for you guys:

when calling svn_client_ls() with path_or_url param as an empty string
(I know, that's a bug in TSVN) then a crash occurs. Since it's wrong to
pass an empty path to that function it's not that important, but still,
I think Subversion shouldn't crash but return an error.

the stacktrace (linenumbers are valid for the 1.1.3 release):
subversion\libsvn_client\ls.c : line 98
subversion\libsvn_ra_dav\props.c : line 1134
subversion\libsvn_ra_dav\props.c : line 893
subversion\libsvn_ra_dav\props.c : line 765
subversion\libsvn_ra_dav\props.c : line 648
subversion\libsvn_subr\svn_string.c : line 235

the crash occurs because the cstring param in svn_stringbuf_create is NULL.


   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jan 26 19:59:03 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.