> --On Wednesday, January 26, 2005 9:22 AM +1100 NormW <firstname.lastname@example.org> wrote:
>> Putting the final touchs to a 'patch' for the SVN package that allows
>> Subversion 1.1.3 to be built on a Windows box for the NetWare platform;
>> is there any interest for this to be included in the SVN package, and if
>> so can attachments (112k zip) be sent to the list for consideration?
Hi, Norm, and welcome. (I'm guessing you're fairly new here.)
Well, a 112 kB zip is a bit too big for the mailing list really. At a pinch,
once in a while, maybe, if you have no way of putting it on a server and
posting the URL instead.
BUT... What would be much more useful is a description of the changes. When we
write a patch we write a log message to go with it which says what the overall
purpose of the patch is, and then, for each file modified, what was modified in
that file (purpose and result, not coding details).
For example, here is the log message from a recent change to the build system:
Teach win-tests.py to fetch the lists of tests directly from build.conf,
rather than having hardcoded lists of its own.
* build.conf (test-scripts): List utf8_tests.py - it is Windows only, but the
test list is now centralized.
* win-tests.py: Remove the hardcoded test lists, and use the build generator
system to find the info from build.conf.
* build/generator/gen_win.py (GeneratorBase): New intermediate class between
gen_base.GeneratorBase and gen_win.WinGeneratorBase, containing the
_extension_map definition for Windows, but no more customizations.
For use when a simple Windows-oriented parse of build.conf is desired,
but the probing for dependency versions is not, i.e. in win-tests.py.
(_extension_map): Remove the unused 'script' type.
Please read the file "HACKING" (in the root of the source code tree) if you
By all means post a URL to your patch file as well, so we can comment on it
Justin Erenkrantz wrote:
> Are most of the changes related to the NetWare build system? It might
> be possible to add a Python generator that can produce the NetWare build
> scripts automagically. (All of the build system stuff is dynamically
> produced from build.conf for both MSVC and Unix.)
It seems probable that most of the size of the patch is due to stuff which is
or could be automatically generated, or imported from elsewhere, and there
wouldn't be much point in showing us those parts.
Thanks for offering your work. Please be prepared for some rounds of review
and modification before we can use it, but if it was worth you writing it and
doesn't impact too much on the rest of the system, then it might well be worth
us including it.
To unsubscribe, e-mail: email@example.com
For additional commands, e-mail: firstname.lastname@example.org
Received on Wed Jan 26 02:09:00 2005