[[[
Avoid using SVN_REVNUM_T_FMT, and document why.
* subversion/include/svn_types.h
(SVN_REVNUM_T_FMT): Document non-use in Subversion source code.
* subversion/clients/cmdline/ls-cmd.c
(print_dirents_xml): Replace SVN_REVNUM_T_FMT with its expansion.
* subversion/svnadmin/main.c
(get_revnum): Replace SVN_REVNUM_T_FMT with its expansion.
]]]
This is a pseudo-patch because my WC is busy with the previous patch and I
don't want to make another WC right now.
Index: subversion/clients/cmdline/ls-cmd.c
===================================================================
/* "<commit revision=...>" */
svn_xml_make_open_tag (&sb, subpool, svn_xml_protect_pcdata, "commit",
"revision",
- apr_psprintf (subpool, "%" SVN_REVNUM_T_FMT,
+ apr_psprintf (subpool, "%ld",
dirent->created_rev),
NULL);
Index: subversion/include/svn_types.h
===================================================================
-/** In @c printf()-style functions, format revision numbers using this. */
+/** In @c printf()-style functions, format revision numbers using this.
+ * Do not use this macro within the Subversion project source code, because
+ * the language translation tools have trouble parsing it. */
#define SVN_REVNUM_T_FMT "ld"
Index: subversion/svnadmin/main.c
===================================================================
--- subversion/svnadmin/main.c (revision 12839)
+++ subversion/svnadmin/main.c (working copy)
@@ -426,8 +426,8 @@ get_revnum (svn_revnum_t *revnum, const
if (*revnum > youngest)
return svn_error_createf
(SVN_ERR_CL_ARG_PARSING_ERROR, NULL,
- "Revisions must not be greater than the youngest revision (%"
- SVN_REVNUM_T_FMT ")", youngest);
+ "Revisions must not be greater than the youngest revision (%ld)",
+ youngest);
return SVN_NO_ERROR;
}
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jan 25 23:31:29 2005