kfogel@collab.net wrote:
> kfogel@collab.net writes:
>> maxb@tigris.org writes:
>>> Log:
>>> Buildsystem cleanup for greater code understandability. No change
>>> to output. Storing arbitrary lists in a dependency graph object
>>> as dependencies of magic targets belongs in an "Obfuscated Python"
>>> competition, not in the Subversion codebase :-) - kill off this
>>> idiom. Also other minor localized tweaks.
>>
>> I think the code referred to is by Greg Stein, who's no shrinking
>> violet and isn't likely to be hurt by such, um, robust criticism :-).
>>
>> But in general, let's please be leery of immortalizing that sort of
>> thing in our commit logs. Maybe save it for IRC, and use a more
>> circumspect phrasing for the actual commit? (And after all, we let it
>> into the codebase -- it passed review, presumably.)
>
> Now I feel all bad. My comments really should have been prefixed with
> "OHMYGOODNESSTHANKYOUTHANKYOUTHANKYOUFORTHECLEANUPSMAXBYOUARETHEDUDE".
> My apologies for the ommission, Max!
/me grins :-)
You're welcome!
There was a smiley in the log message too, in line with the intended tone of
"friendly teasing" - but now you mention it, I do see your point that the
same words, with a different inflection, can take on a rather unpleasantly
harsh tone.
Max.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jan 20 01:03:06 2005