[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Limit size of emails sent using commit-email.pl

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2005-01-19 23:52:56 CET

kfogel@collab.net writes:

> "C. Michael Pilato" <cmpilato@collab.net> writes:
> > We didn't integrate ViewCVS support into mailer.py because we didn't
> > want to get into the game of endorsing particular repository browser
> > programs. We won't do so for commit-email.pl either.
> >
> > Further, having already *done* this very commit-email.pl/ViewCVS
> > integration myself (for CollabNet), let me assure you that we *DO NOT*
> > want Sameer (or anyone) wasting time on such a painful (and
> > not-fully-solvable) problem. svnlook simply doesn't yield enough
> > information to get this right.
> What I was thinking of was a URL into which could be plugged two
> revision numbers. The URL would be user-configurable. (Any diff
> functionality is going to take exactly two revision numbers, right?
> Or is that overly optimistic?)

ViewCVS needs two or three revisions (peg, source, dest) and one to
three paths (path, source, dest). I have no idea what WebSVN or any
of the other various browsers needs.

> svnlook needn't be involved in this at all. See Sameer's original
> patch for why not.

Okay, maybe not svnlook. But you need some way of finding out the two
things to compare -- the "left" path and revision, and the "right"
path and revision. Bindings aren't an option (since the whole point
of commit-email.pl is to avoid using the bindings) and no existing
Subversion binary provides that information correctly.

(Again, I've written this support once, and remember what I needed and
didn't need.)

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jan 19 23:58:04 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.