[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r12757 - trunk/build/generator

From: <kfogel_at_collab.net>
Date: 2005-01-19 20:33:35 CET

maxb@tigris.org writes:
> Log:
> Buildsystem cleanup for greater code understandability. No change to output.
> Storing arbitrary lists in a dependency graph object as dependencies of magic
> targets belongs in an "Obfuscated Python" competition, not in the Subversion
> codebase :-) - kill off this idiom. Also other minor localized tweaks.

I think the code referred to is by Greg Stein, who's no shrinking
violet and isn't likely to be hurt by such, um, robust criticism :-).

But in general, let's please be leery of immortalizing that sort of
thing in our commit logs. Maybe save it for IRC, and use a more
circumspect phrasing for the actual commit? (And after all, we let it
into the codebase -- it passed review, presumably.)

Just my $0.02,

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jan 19 20:43:09 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.