[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Keywords as hash - Final(?) submission

From: John Peacock <jpeacock_at_rowman.com>
Date: 2005-01-17 00:45:35 CET

Philip Martin wrote:
> Apart from some interface queries my comments are mainly whitespace
> issues. I don't have any strong feelings about issue 890 (I don't
> use keywords) but the code looks reasonable.

Thanks for the detailed criticism. I hadn't thought of apr_hash_t** being that
much more efficient, but you are right, that would be a better API. In all
honesty, some of the less efficient bits of this are due to the incremental
changes to the patch over time. If the compatibility functions have to allocate
a pool (since they don't have one to give), that was just something that I had
to live with, for example.

I'll go over your suggestions and implement them (don't know if it will be
tonight). I'll also add the changes to the svn propset help text (forgot about
that one).

Thanks again!


John Peacock
Director of Information Research and Technology
Rowman & Littlefield Publishing Group
4720 Boston Way
Lanham, MD 20706
301-459-3366 x.5010
fax 301-429-5747
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jan 17 00:49:47 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.