[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Enforce canonical paths in client-server protocol?

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2005-01-16 19:53:18 CET

Greg Hudson wrote:
> On Sun, 2005-01-16 at 12:31, Julian Foad wrote:
>>What I'm saying is all a consequence of my opinion that we should enforce
>>protocols strictly.
> As a general rule, I agree.
> But in this specific instance, I don't see any value in going to
> additional effort (and perhaps breaking clients) to strictly enforce
> canonical paths.

Ah, but it's not additional effort. There are actually three implementation

+ explicitly reject non-canonical paths;

+ explicitly accept non-canonical paths;

+ don't check; just work if good paths are given and behave indeterminately
(work/fail/crash) if bad paths are given.

The effort to reject or accept non-canonical paths is equal. The only
low-effort approach is to just try to use the paths without checking, but that
already led to crashes in svnserve so it was deemed unacceptable.

Given that the two acceptable approaches require equal effort, the "perhaps
breaking clients" is the determining factor, and we haven't determined how much
of a problem that is. If it's a big problem then I'll agree it won't be worth it.

- Julian

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Jan 16 19:54:32 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.