Re: svn and automatic line ending

karl@freefriends.org (Karl Berry) writes:

> 1) [easy] multi-file adds of mixed binary and text files still fail
> after removing that error, because of another check, at the end of that
> same function (validate_eol_prop_against_file in
> subversion/libsvn_wc/props.c):
>
> if (err && err->apr_err == SVN_ERR_IO_INCONSISTENT_EOL)
> return svn_error_createf (SVN_ERR_ILLEGAL_TARGET, err,
> _("File '%s' has inconsistent newlines"), path);
>
> I made this into a do-nothing, and the add then completed ok.

That's the wrong place to do it as it makes the propset succeed.

>
> 2) [hard] The commit fails, even though the add succeeded:
>
> svn: File 'whatever' has inconsistent newlines

I *think* that what you need to do is modify libsvn_client. Somewhere
during add the auto-props are retrieved and passed to svn_wc_prop_set2
and you need to detect when SVN_ERR_IO_INCONSISTENT_EOL is returned
and ignore it, possibly generating some sort of feedback.

If you get something that works and want to submit a patch then read
http://svn.collab.net/repos/svn/trunk/HACKING

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org