Re: svn commit: r12738 - in trunk/subversion: include libsvn_subr mod_dav_svn

"Peter N. Lundblad" <peter@famlundblad.se> writes:
> With "fixing symptoms" I was referring to the use of a function that
> doesn't actually make sure that the paths are canonical. It fixes the
> assertion failures (symptom), but doesn't fix the real problem (making
> sure that paths are in canonical form). When you use a function, you
> should make sure it does what you want. Since this function is internal,
> and undocumented, this means reading the code:-)

Okay, okay -- no need to lecture Mike Pilato on how to be a good
programmer, he's plenty thorough already. Anyone can misread some
code, all you need to do is point out the bug and let him fix it. No
need to go beyond that.

Regarding the overall approach: I feel that Julian Foad's point about
being strict now and loosening later if we want is a good one.

> BTW, when I said we might still have other bugs in this fix, I menat that
> something in svn_path might depend on other properties of a canonical path
> than is_canonical enforces. These might be crashes as well. I don't
> know, because I haven't checked.

Erp -- sorry, I read this three times but don't understand what you
meant. Try explaining another way?

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jan 15 21:14:42 2005