[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Detect EOF during propmt

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2005-01-15 01:30:30 CET

David Wilson <dw@botanicus.net> writes:

> $ svn co https://china.botanicus.net/svn/cdr_mysql < /dev/null

If you are running svn from a crontab then using --non-interactive
will cause it to fail rather than spin.

Does anybody understand why EOF is ignored? Even if it's some magic
Window's stuff, I don't think it's sensible to use c after EOF. How
about this:

Index: subversion/clients/cmdline/prompt.c
===================================================================
--- subversion/clients/cmdline/prompt.c (revision 12736)
+++ subversion/clients/cmdline/prompt.c (working copy)
@@ -112,7 +112,7 @@
             return svn_error_wrap_apr (status, _("Can't read stdin"));
              
           status = apr_file_getc (&c, fp);
- if (status && ! APR_STATUS_IS_EOF(status))
+ if (status)
             return svn_error_wrap_apr (status, _("Can't read stdin"));
 
           if (saw_first_half_of_eol)

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jan 15 01:31:44 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.