On Thu, Jan 13, 2005 at 09:07:00AM +0000, Hugh Gibson wrote:
> > > Do you have unit tests for it? That would be important for testing
> > > any new implementation.
> >
> > I wish we had unit tests for it. That would be important for testing
> > any new implementation.
>
> Hmmm. How many unit tests are there for SVN in general?
>
Lots. Really. SVN has a great unit test framework. But only two tests
have been written for blame, and neither of those address the blame
calculation directly.
Run "make check" if you've got a lot of time on your hands. You can
look in subversion/tests/clients/cmdline/blame_tests.py for what we've
got in the way of blame testing.
The right thing to do is probably to generalize the blame calculation
routines and move them to libsvn_subr (or perhaps libsvn_diff), and
add real unit tests to subversion/tests/libsvn_subr. This would
lower the barrier to moving the blame calculation to the server side,
too.
[...]
>
> Also, is it OK to pass wildcards to svn blame? I tried using * but got an
> error message back from the server, which appeared to be complaining about
> a folder with just a single file in it, which had no revisions (just the
> initial checkin). I wasn't sure if that was a problem in what I was doing,
> or with our SVN repository, or with SVN itself.
The wildcards are expanded by the shell on unixy systems, and by magical
linker tricks on Windows. That is to say, none of Subversion's code
handles command-line wildcards directly. That means that it's always
okay to pass wildcards to Subversion.
Is it possible that the wildcard expanded to a directory name, and that
blame doesn't produce a nice looking message when run on a directory?
--ben
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jan 13 12:43:46 2005