[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r12683 - branches/locking/subversion/libsvn_fs_fs

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2005-01-12 23:28:33 CET

fitz@tigris.org writes:

> Author: fitz
> Date: Wed Jan 12 13:18:44 2005
> New Revision: 12683

> --- branches/locking/subversion/libsvn_fs_fs/lock.c (original)
> +++ branches/locking/subversion/libsvn_fs_fs/lock.c Wed Jan 12 13:18:44 2005

> + err = svn_io_file_read_full (fd, buf, nbytes, &nbytes, pool);
> +
> + if (err && APR_STATUS_IS_EOF (err->apr_err))
> {
> - apr_file_close(fd);
> - return svn_error_wrap_apr (status,
> - _("Error reading lock entries file '%s.'"),
> - path);
> + svn_error_clear (err);
> + break;
> + }
> + if (err)
> + {
> + SVN_ERR (svn_io_file_close (fd, pool));

If svn_io_file_close fails then err leaks.

> + return err;
> }

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jan 12 23:29:43 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.