[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Request: make the user agent string a define

From: SteveKing <steveking_at_gmx.ch>
Date: 2005-01-08 21:20:17 CET

Erik Huelsmann wrote:
>>Just think of a client which has a bug and doesn't properly UTF8 encode
>>and/or check the lineendings before calling that function. Then you'll
>>end up with unwanted data in the repository which other clients don't
>>understand anymore.
> It's a bug in the server if it accepts data which should be utf-8
> encoded, but is not. The docstring tells you the libraries rely on the
> client to do the UTF-8 encoding. It's up to the server to check. Next
> to that, it's Subversion protocol documentation.

At the time TSVN had that bug, the server didn't reject the commits from
it. So at that time, the Subversion server had that bug (don't know if
it's still there, haven't tested).

So, you discover that a client has a bug and the server doesn't reject
the commit. Now what do you do? The only thing you can do is wait for a
new release of the server, but that will take some time because such a
bug is not urgent enough (after all, it's the client who sends garbage
data). During the time in which you wait for a new server release, you
can then only pray that all your users don't use that broken client
anymore - not a very good scenario if you ask me.

But let's kick aside the why and what for that feature is needed and
what would be different and in your opinion much better solutions.
Let's just accept that users want such a feature, even if you don't
understand why they want it.

So would it be possible to make that user-agent string so that a client
can change it? I'd really hate it if I had to patch Subversion too - I
already had to do it with apr-iconv...


   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jan 8 21:21:22 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.