On Tue, Jan 04, 2005 at 09:32:01PM -0700, Jani Averbach wrote:
> On 2005-01-04 17:18-0800, Justin Erenkrantz wrote:
> >
> > Looks good. I tweaked it slightly (removed the $(SHELL) part for
> > apr-libtool code path) and committed it in r12591. Thanks! -- justin
> >
> Thanks Justin!
>
> I am not objecting what you did, but would like to know better, so:
>
> AC_PROG_LIBTOOL will expand (at least here) to
> $(SHELL) $(top_builddir)/libtool
> and we are using a same kind of form for SVN_LIBTOOL.
>
> Why don't we use $(SHELL) for apr's libtool? I thought that using an
> explicit shell for it would be a good thing to do, at least because of
> consistency, if not otherwise?
$(SHELL) is generally only needed if the script isn't executable. It's a
generally safe assumption that APR will have the executable bit set. However,
and more importantly, APR comes with a variety of libtool replacements that
aren't shell scripts, but real C executables. So, a $(SHELL) prefix for them
would be invalid and wouldn't work.
FWIW, the experimental libtool option is mainly in place so that I don't have
to use GNU libtool: speeds my builds up by a factor of 2 or more... -- justin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jan 5 08:44:15 2005