Re: [PATCH] Speed up svn:externals updates by using an internal "svn switch" rather than a straight delete.

Ross Mark <rossm@controllingedge.com.au> writes:

> Philip Martin wrote:
>
>>What's the reason for calling svn_client_cleanup? Given that cleanup
>>will steal WC locks it's probably not the right thing to do.
>>
> The problem is, if the new url for the externals entry points to a
> different repository the attempted switch obtains the locks then bails
> out leaving the locks once it realise that the repositories are
> different. This is the one part of the process that I didn't like and
> am happy to take any suggestions.

I see, that happens because a failed switch doesn't explicitly close
the access baton leaving pool cleanup to remove unnecessary locks.
How about something like:

    /* Note: using a subpool to cleanup WC locks if the switch fails */
    apr_pool_t *subpool = svn_pool_create (pool)
    err = svn_client_switch (... subpool);
    svn_pool_destroy (subpool);
    if (err)
      {
          // No call to svn_client_cleanup required
      }

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org