Kouhei Sutou wrote:
> Hi,
>
> I'm writing Ruby SWIG-based bindings.
> http://pub.cozmixng.org/~kou/diff/svn-add-ruby-20050104.diff
>
> This is not complete yet. But some examples work:
>
> * tools/examples/svnshell.rb: Ruby version of
> tools/examples/svnshell.py.
>
> * tools/examples/svnlook.rb: Ruby version of
> tools/examples/svnlook.py.
>
>
> I want to administrate my codes by version control system.
> I'm afraid of loosing my codes by human error.
> Could you let me use http://svn.collab.net/repos/ to do?
This stuff looks fantastic, and I'd love to see it committed. A few
minor comments though.
First of all, there seem to be some parts of the diff that change things
that aren't specific to the ruby bindings, and the whole thing really
needs a log message indicating what it's doing so that it can be more
easily reviewed. It may be easier to do that if you break it up into
multiple smaller patches.
Second, the Svn::Client stuff seems a bit suboptimal to me. I don't
really like how the Context object is being passed in manually to each
function, it doesn't feel very object oriented. You might want to take
a look at the way the perl bindings work, where there's a SVN::Client
object that includes the context and automagically adds it to each
method call. See subversion/bindings/swig/perl/native/Client.pm for
details on how this is being done there.
All in all I think you're making good progress though, and I'd love to
help get this committed and hopefully eventually get you access to
maintain it directly in the tree.
-garrett
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jan 4 18:39:48 2005