Re: suggestion for more custom keyword options (Issue 890)

I've starting bringing my keywords as hash patch up to date (currently testing
phase 1) and I wanted to implement these suggested additions at the same time.
But I have questions:

John Belmonte wrote:
> As part of Issue 890 (custom keywords), I would like to see two more
> options for the keyword values:
>
> * repository-local path of file

This one is hard, since there appears to be no way to go from entry->url (what
I've got to work with) to just the repository local portion. This appears to be
something the client is not privy to. Am I missing something obvious in
svn_path.h? If I can figure out how to do this, we need a good keyword for this
concept:

#define SVN_KEYWORD_LOCAL_LONG "RepositoryLocalPath"
#define SVN_KEYWORD_LOCAL_MEDIUM "LocalPath"
#define SVN_KEYWORD_LOCAL_SHORT "Local"
#define SVN_KEYWORD_LOCAL_FORMAT "%L"

I prefer not to use %l for the format letter, as that is easy to confuse with %i.

> * repository UUID
>

This one is easy; I just add entry->uuid to the svn_subst_build_keywords2()
calls and display it. I would suggest the following definitions, though:

#define SVN_KEYWORD_UUID_LONG "RepositoryUUID"
#define SVN_KEYWORD_UUID_SHORT "UUID"
#define SVN_KEYWORD_UUID_FORMAT "%U"

I prefer not to use %i because it is too easy to confuse with %l. I'd be just
as happy to only have the SHORT form here, instead of both, but it doesn't
matter much to me.

TIA

John

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Dec 30 12:19:36 2004