[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [BUG?] svn_path_join_many doesn't check for NULL

From: Ben Reser <ben_at_reser.org>
Date: 2004-12-23 08:57:00 CET

On Thu, Dec 23, 2004 at 08:24:19AM +0100, Ph. Marek wrote:
> in svn-1.1.2 I see the following statement
> (subversion/libsvn_subr/path.c:218):
> path = p = apr_palloc (pool, total_len + 1);
> I believe it is possible (if unlikely) to receive a NULL value here (if memory
> is full).
> But the return value is not checked for NULL!
> The trivial patch below moves the same problem a bit downwards to the callers;
> they'd have to be done too.

No we always call abort() if memory is full.

Ben Reser <ben@reser.org>
"Conscience is the inner voice which warns us somebody may be looking."
- H.L. Mencken
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Dec 23 08:58:13 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.