[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] issue 1954 - v6

From: VK Sameer <sameer_at_collab.net>
Date: 2004-12-20 07:18:37 CET


Sorry about the delay in getting back. Philip's email made me go back
and verify a lot of unwritten notes. This is my current understanding of
the issue and code flow, please feel free to pound on it :):

* the issue is to check for validity of svn pathnames provided to the
add and import commands. Putting the check in svn_wc_add covers add,
copy, and move (and merge, according to Philip, though I haven't
verified this).

* Valid svn pathnames are UTF-8 sequences that do not contain control
characters. This does not address the issue of encoded control
characters in URIs.

- Putting the check in libsvn_wc:adm_opts.c:svn_wc_add() covers
svn_client_add(), svn_client_copy(), and svn_client_move2().

- libsvn_client:commit.c:import_file() and import_dir() are used to
cover svn_client_import() since they don't call functions in libsvn_wc.

The updated patch is attached. (libsvn_wc/{copy.c, update_editor.c} and
libsvn_client/add.c) have been removed.


Resolve issue #1954: Error on add or import of a path that is
invalid in Subversion.

* subversion/include/svn_path.h, subversion/libsvn_subr/path.c
  (svn_path_check_valid): New function.

* subversion/libsvn_wc/adm_ops.c
  (svn_wc_add): Call svn_path_check_valid().

* subversion/libsvn_client/commit.c
  (import_file, import_dir): Same.

* subversion/libsvn_ra_svn/client.c
  (ra_svn_check_path): Same

* subversion/libsvn_ra_dav/props.c
  (svn_ra_dav__do_check_path): Same

* subversion/tests/clients/cmdline/commit_tests.py
  (tab_test): New test.
  (test_list): Added tab_test.
  (commit_uri_unsafe): Moved tab test parts to tab_test.

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Mon Dec 20 07:19:52 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.