[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: SWIG Again

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2004-12-20 00:40:09 CET

John Lenz <lenz@cs.wisc.edu> writes:

> The problem is that swig-build-preinst actually becomes the default rule,
> so you need to move it below all: something like the following patch.

In general it's better to post the whole patch rather than incremental
patches (although I guess you probably posted the incremental for my
benefit), a log message would be good as well.

> Note as well that using --with-swig just means that you are passing a
> string to an already built SWIG. That is, configure searches for an
> installed SWIG in PATH, but if for some reason it is not installed in path,
> you can pass --with-swig to tell it where (say you installed it in /opt or
> something).

That's what I want.

> This option is from before, and has no impact on the new way
> to build SWIG.
>
> The only way (I currently have) subversion building swig as part of its own
> build process is if a SWIG directory is located in the top level subversion
> source. I can change this, but it would be to add another argument like --
> with-swig-source or something.

I have no interest in having Subversion build SWIG.

> --- subversion/Makefile.in~newpatch
> +++ subversion/Makefile.in
> @@ -128,9 +128,6 @@
> SWIG_JAVA_LINK = @SWIG_JAVA_LINK@
> SWIG_PL_INCLUDES = @SWIG_PL_INCLUDES@
>
> -swig-build-preinst:
> - if test "@SWIG_BUILD_PREINST@" -eq "1"; then cd SWIG && make; fi
> -
> JAVAHL_INCLUDES= @JNI_INCLUDES@ -I$(abs_builddir)/subversion/bindings/
> java/javahl/include
>
> SVN_APR_INCLUDES = @SVN_APR_INCLUDES@
> @@ -262,6 +259,10 @@
> extraclean: external-extraclean local-extraclean
> install: external-install local-install revision-install
>
> +swig-build-preinst:
> + if test "@SWIG_BUILD_PREINST@" -eq "1"; then cd SWIG && make; fi

Use a leading @ to supress output. Why don't you add SWIG to the
existing external-all target?

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Dec 20 00:41:15 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.