Re: svn commit: r12384 - branches/1.1.x-r12327/subversion/libsvn_repos

"Max Bowsher" <maxb@ukf.net> writes:

> Philip Martin wrote:
>> maxb@tigris.org writes:
>>
>>> + err = svn_fs_commit_txn (&conflict_msg, &(*new_rev), rb->txn,
>>> rb->pool);
>>
>> Why "&(*new_rev)" and not just "new_rev"?
>
> Deliberate to emphasise it's role as an output parameter.

How bizarre! I've never seen that idiom before, I find it confusing,
and I don't think it's a good idea.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org