[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r12327 - trunk/subversion/libsvn_repos

From: Justin Erenkrantz <justin_at_erenkrantz.com>
Date: 2004-12-16 22:03:58 CET

--On Thursday, December 16, 2004 2:44 AM +0000 Max Bowsher <maxb@ukf.net>
wrote:

> This patch was written at 2am during an IRC conversation on #cvs2svn with
> jerenkrantz, who discovered the bug when trying to load a newly converted
> project into the ASF main repository.

Correct. With this fix, we were able to load the dump file into the live
repository without any race conditions.

> Whilst I feel confident in the change, given that it went through the entire
> cycle of debug->commit in less than an hour, at 2am in the morning, I'd
> quite like a review on this one.

Well, Fitz, Sussman, and I were also in #cvs2svn at the same time and we all
agreed that this was the right fix. I also reviewed the patch before I merged
it into our install on apache.org. So, I'm confident on this patch (or as
much as I can be).

I think this needs to get into 1.1.2 as well as this is a gnarly race
condition that will hose the load: so I've proposed it for backport in STATUS.
-- justin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Dec 16 22:06:45 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.