On Wed, 2004-12-15 at 07:25, Julian Foad wrote:
> VK Sameer wrote:
> >>>+ return svn_error_createf (SVN_ERR_FS_PATH_SYNTAX, NULL,
> >>>+ "Invalid control char. '%x' in path '%s'",
> >>>+ *c,
> >>>+ svn_path_local_style (path, pool));
> [...]
> > Done. It was there initially - got removed during vain attempts at
> > staying within 72 cols.
>
> A width of 72 columns is good for e-mail prose to allow for quoting in replies,
> but up to 79 or maybe 80 is fine for source code.
OK.
> Here are two other ways used in Subversion source code to reduce the column count.
>
> Use the fact that adjacent strings are combined by the compiler, e.g.:
>
> return svn_error_createf (SVN_ERR_FS_PATH_SYNTAX, NULL,
> "Invalid control char. '%x' "
> "in path '%s'",
> *c,
> svn_path_local_style (path, pool));
>
> Start the argument list on a new line (indented by 2 spaces):
>
> return svn_error_createf
> (SVN_ERR_FS_PATH_SYNTAX, NULL,
> "Invalid control char. '%x' in path '%s'",
> *c,
> svn_path_local_style (path, pool));
This looks much nicer, to my admittedly biased eyes. I used to work with
somebody who coded like this:
f1 (
arg1,
f2 (
arg21,
arg22,
f3 (
arg31,
arg32
)
),
...,
argN
);
Regards
Sameer
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Dec 15 05:17:14 2004