Re: IS_FNCHAR ok to use?

On Tue, 2004-12-14 at 13:55, Peter N. Lundblad wrote:
> On Tue, 14 Dec 2004, VK Sameer wrote:
>
> > While checking out the fix for issue 1954, Jon Foster's patch took me to
> > IS_FNCHAR (in include/arch/win32/apr_arch_file_io.h) for testing whether
> > pathnames contain invalid/reserved characters on Windows. Is it ok to
> > use this even though it has no APR_ prefix?
> >
> Have we decided that we want this check inside svn at all?

I haven't brought up the proposal before. Not sure if it has been
discussed earlier.

> I'm not sure I think that's a good idea.

Using IS_FNCHAR or os-specific checks altogether?

> When would you do this check?

It would be part of a check for os-specific characters before creating
and adding a file in a working copy.

These are the files:
subversion/libsvn_wc/copy.c
subversion/libsvn_wc/adm_ops.c
subversion/libsvn_wc/update_editor.c
subversion/libsvn_client/copy.c

Regards
Sameer

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Dec 14 10:11:50 2004