Re: svn commit: r12235 - in branches/locking/subversion: include tests tests/libsvn_delta tests/libsvn_diff tests/libsvn_fs tests/libsvn_fs_base tests/libsvn_repos tests/libsvn_subr tests/libsvn_wc

On Dec 9, 2004, at 8:53 PM, Branko Čibej wrote:

> fitz@tigris.org wrote:
>
>> Author: fitz
>> Date: Tue Dec 7 22:58:31 2004
>> New Revision: 12235
>>
>
>> Log:
>> Change the C testsuite to allow testing of the fsfs backend by passing
>> --fstype=fsfs.
>>
> Typo here? Should probably be --fs-type.

Yep, a typo.

>> * subversion/tests/libsvn_fs/run-fs-tests.py: Fix call to run-tests to
>> run locks-test.
>>
> Question:
>
>> Modified: branches/locking/subversion/tests/libsvn_fs/run-fs-tests.py
>> Url:
>> http://svn.collab.net/viewcvs/svn/branches/locking/subversion/tests/
>> libsvn_fs/run-fs-tests.py?view=diff&rev=12235&p1=branches/locking/
>> subversion/tests/libsvn_fs/run-fs-tests.py&r1=12234&p2=branches/
>> locking/subversion/tests/libsvn_fs/run-fs-tests.py&r2=12235
>> ======================================================================
>> ========
>> ---
>> branches/locking/subversion/tests/libsvn_fs/run-fs-tests.py
>> (original)
>> +++ branches/locking/subversion/tests/libsvn_fs/run-fs-tests.py Tue
>> Dec 7 22:58:31 2004
>> @@ -9,8 +9,7 @@
>> # Run the tests
>> import exectest
>> -errors = exectest.run_tests(['key-test', 'skel-test',
>> - 'strings-reps-test', 'fs-test'])
>> +errors = exectest.run_tests(['locks-test'])
>> sys.exit(errors)
>>
> Why disable the other tests?

They're not disabled--it was a cut-and-paste error from when I copied
the script from tests/libsvn_fs_base. Those tests still take place
over there--tho I'd like to move any non-bdb specific tests into this
directory at some point in the future.

> Otherwise, nice work! We've needed this, like, forever.

Thanks! I greatly prefer test driven development, so it's a purely
selfish move. :-)

-Fitz