Re: svn commit: r12262 - in branches/locking/subversion: libsvn_fs_fs tests/libsvn_fs

On Dec 9, 2004, at 12:29 PM, Philip Martin wrote:

> fitz@tigris.org writes:
>> +
>> + /* Skip directories. */
>> + if (finfo->filetype == APR_DIR)
>> + return SVN_NO_ERROR;
>> +
>> + /* Get the repository-relative path for the lock. */
>> + SVN_ERR (base_path_to_lock_file (&base_path, dir_baton->fs, pool));
>> + rel_path = path + strlen(base_path);
>
> That looks just a little fragile. It probably works, but base_path is
> constructed using apr_filepath_merge while svn_io_dir_walk uses the
> svn_path functions, will they always be consistent?

Hmmm. Any suggestions? I initially used svn_path_join_many, but shied
away since the docstring said to only use it for "internal"
canonicalized paths.

All other fixes applied in r12265.

Thanks!

-Fitz

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Dec 10 04:12:50 2004