Re: Subversion's use of Berkeley DB [#11511]

Philip Martin <philip@codematters.co.uk> writes:

> Should be simple to implement, but I don't know what sort of
> performance effect it would have. Do we really want to run recovery
> that often?

A quick 'n' dirty implementation

Index: subversion/libsvn_repos/repos.c
===================================================================
--- subversion/libsvn_repos/repos.c (revision 12263)
+++ subversion/libsvn_repos/repos.c (working copy)
@@ -1075,6 +1075,9 @@
     const char *lockfile_path;
     svn_error_t *err;
 
+ if (! exclusive)
+ SVN_ERR (svn_repos_recover2 (path, TRUE, NULL, NULL, pool));
+
     /* Get a filehandle for the repository's db lockfile. */
     lockfile_path = svn_repos_db_lockfile (repos, pool);

$ time for i in `seq 1 30`;do svn st -u wc > /dev/null;done

Without patch:
real 0m15.294s
user 0m2.450s
sys 0m0.620s

With patch:
real 0m24.186s
user 0m3.620s
sys 0m1.480s

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org