Re: Subversion's use of Berkeley DB [#11511]

[ dropping Sleepycat CCs ]

--On Thursday, December 9, 2004 11:16 PM +0100 "Branko ?ibej"
<brane@xbc.nu> wrote:

> Justin Erenkrantz wrote:
>...
>> No, it's not. We should add an RA method that indicates that the
>> process is being initialized and advise SVN to perform recovery.
>
> You'd put FS back-end implementation details in an RA method? Yikes.

No. It'd just be a 'svn_repos_init' or something similar, which could call
fs_init or whatever.

> This would also imply that mod_dav_svn opens every repository it's
> configured for in the post-config hook, and keeps it open for the
> lifetime of the httpd process. AFAIK these days mod_dav_svn opens the FS
> for every request, more or less; and you have to do the check at every
> fs_open, not in some RA method.

mod_dav_svn already caches the fs/repos. And, we wouldn't need to keep it
open after it checks: it'd just need to ensure that it is an safe state.

I think placing the check in fs_open is not going to work out well because
it'd be really expensive to do any type of shmem check there. So, I think
the check needs to be explicit somewhere else and done as early as possible
- in the case of mod_dav_svn, in a post config hook. -- justin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Dec 10 03:09:55 2004