[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r12171 - trunk/subversion/libsvn_subr

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2004-12-07 16:40:29 CET

On Mon, 6 Dec 2004, Philip Martin wrote:

> "Peter N. Lundblad" <peter@famlundblad.se> writes:
>
> > On Sun, 5 Dec 2004 philip@tigris.org wrote:
> >
> >> Modified: trunk/subversion/libsvn_subr/utf.c
> >> Url: http://svn.collab.net/viewcvs/svn/trunk/subversion/libsvn_subr/utf.c?view=diff&rev=12171&p1=trunk/subversion/libsvn_subr/utf.c&r1=12170&p2=trunk/subversion/libsvn_subr/utf.c&r2=12171
> >> ==============================================================================
> >> --- trunk/subversion/libsvn_subr/utf.c (original)
> >> +++ trunk/subversion/libsvn_subr/utf.c Sun Dec 5 17:06:29 2004
> >> @@ -443,7 +442,7 @@
> >> (unsigned char)last[i-valid]),
> >> NULL);
> >> msg = apr_pstrcat (pool, msg,
> >> - ")\nfollowed by invalid UTF-8 sequence\n(hex:", NULL);
> >> + _(")\nfollowed by invalid UTF-8 sequence\n(hex:"), NULL);
> >>
> >> /* 4 invalid octets will guarantee that the faulty octet is displayed */
> >> invalid = data + len - last;
> >> @@ -452,7 +451,7 @@
> >> for (i = 0; i < invalid; ++i)
> >> msg = apr_pstrcat (pool, msg, apr_psprintf (pool, " %02x",
> >> (unsigned char)last[i]), NULL);
> >> - msg = apr_pstrcat (pool, msg, ")", NULL);
> >> + msg = apr_pstrcat (pool, msg, _(")"), NULL);
> >>
> >
> > Ooops, how wold you translate that string? In cases like this, you need to
> > keep the translated string together, by preparing the replacable part
> > first in a separate string.
>
> Which string?
>
Look at the line right above what I wrote. There, you will see _(")").
This is a message fragment, which is problematic for translators. See the
gettext manual for more info.

Regards,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Dec 7 16:41:14 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.