[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: SVN need to delete/create-temp/rename files instead of simply ove rwriting them (suggestion how to workaround)

From: Teblin, Ivan <Ivan_Teblin_at_avertlabs.com>
Date: 2004-12-06 11:54:46 CET

> That's possible, although if it involves additional copying it might
> not be welcomed by those that already think Subversion is too slow.

Sure, that's why I suggested it as an option thus not affecting the default
behaviour. Well, not "--fastsave" in this case :-) but something like
"--preserve-file-props" I don't really care about the option's name aiming
just to get the functionality.

> One would have to make sure that repeating an interrupted operation
> didn't cause the backup to get overwritten with junk.

Ok, I see it is really necessary to keep the same scheme with creating temp
file but it's still possible to change the very last renaming operation to
copy operation, thus acting without destroying the original file object. Of
course, I'll try to make the new copying mode to behave no worse than
renaming mode. To ensure this, the only additional thing to do is handling
interruptions during copying routine. Anyway, keeping file properties
personally for me is much-much more important feature than atomicness of
downloads because I don't see any problem to repeat the last SVN command
again in case of networking or whatever error.

> Patches, as ever, welcome! Is that unfair?

I am going to produce the fix for myself anyway, may be not so soon as I
think, because still have to carry my main job and X-mas is coming! But if
talking about patches welcomeness, I can quote Ben Collins-Sussman: "I don't
think we would accept such a patch." ;-) Although I don't really care
whether it will go into that main development because I'm glad to see not
only me is concerned about this problem, so hopefully those people would be
happy to apply the fix after it happened to be produced.

Ivan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Dec 7 08:00:42 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.