Peter N. Lundblad wrote:
>On Sun, 5 Dec 2004, Philip Martin wrote:
>
>
>
>>Norbert Unterberg <nepo@gmx.net> writes:
>>
>>
>>
>>>const char *replies = _("RrTtPp"); /* allow l10n */
>>>
>>>...
>>>
>>> svn_stringbuf_appendcstr
>>>
>>> (buf, _("(R)eject, accept (t)emporarily or accept (p)ermanently? "));
>>>
>>>...
>>>
>>> SVN_ERR (prompt (&choice, buf->data, FALSE, ctx, pool));
>>>
>>> if (choice && (choice[0] == replies[2] || choice[0] == replies[3]))
>>>
>>> { ... }
>>>
>>>
>>I think it assumes that the replies are represented by single bytes.
>>While that may be acceptable for western languages does it apply to
>>things like Chinese? Hmm, our prompt code doesn't appear to handle
>>multiple byte replies either :(
>>
>>
>>
>>
>It most probably doesn't. We need code to get UTF8 *characters* from a
>string. Something like:
>svn_error_t *
>svn_utf_next_char(unsigned &code, const char **follow, const char *pos);
>
>
You're going to break your head ate verey turn if you try to handle
multibyte sequences like that. The only reasonable solution here is to
use wide chars instead of UTF-8 in such places. Which, after a while,
meanse everywhere (and convert to UTF-8 when doing network I/O)
But this is a really huge amount of work.
-- Brane
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Dec 7 00:46:30 2004