[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r12175 - branches/locking/subversion/libsvn_fs_fs

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2004-12-07 00:03:44 CET

kfogel@collab.net wrote:
> Garrett Rooney <rooneg@electricjellyfish.net> writes:
>
>>>An escaping mechanism would be much more readable and debuggable. It
>>>would preserve as much of the filename as possible.
>>>Of course, it has to be an escaping mechanism that escapes itself,
>>>similar to "%" in C string formatting (though "%" itself may not be
>>>the best choice for native filesystem portability).
>>
>>An escaping mechanism won't do anything to solve path length issues.
>
>
> I didn't claim it would. There's no reason to think path length
> issues are worse with escaping than with MD5, statistically. However,
> one of them preserves readability some of the time.

I was thinking that if we're going to try to avoid problems with hitting
invalid characters on the host system we might as well try and avoid
going over the maximum path length as well. One way to do that would be
to put all the locks into a single directory, using a hash of the entire
path to name the files. If we're worried about the number of items in
the directory we could just split into subdirectories based on the first
few characters in the hash.

Of course the files would have to store their full path name internally,
for sanity checking, and there would need to be some mechanism for
avoiding collisions in the hash.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Dec 7 00:05:55 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.