[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r12157 - trunk/subversion/libsvn_subr

From: John Szakmeister <john_at_szakmeister.net>
Date: 2004-12-06 00:19:11 CET

Philip Martin wrote:
> jszakmeister@tigris.org writes:
>>Author: jszakmeister
>>Date: Sat Dec 4 20:32:42 2004
>>New Revision: 12157
>>+ utf8_error:
>>+ if (error_stream)
>>+ fprintf (error_stream, "Can't convert module path to UTF-8");
>>+ return EXIT_FAILURE;
>> }
> ../svn/subversion/libsvn_subr/cmdline.c: In function `svn_cmdline_init':
> ../svn/subversion/libsvn_subr/cmdline.c:224: warning: label `utf8_error' defined but not used

Would the attached patch be acceptable? I was trying to follow trends
that were elsewhere in the code... unfortunately, none of them had to
worry about the preprocessor conditionals. The only thing I don't like
about this is that the label is a little buried, so it may not be
immediately apparent where your jumping to. That's why I avoided it the
first time around.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Dec 6 00:20:38 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.