Re: svn commit: r12093 - branches/locking/subversion/mod_dav_svn

Ben Collins-Sussman wrote:

> I think circular dependencies are the problem. Do we really need to
> create a whole new libsvn_fs_util library? We've been flirting with
> the idea for months. We keep coming to the edge, then backing off.

yah...

> Maybe there's a simpler solution here. We've already defined the
> transparent svn_lock_t structure in svn_types.h, since almost every
> library needs to use it. Perhaps we can create
> svn_generate_locktoken() in libsvn_subr. That already seems to be our
> universal 'utility' library.

Hmmm. Granted that svn_lock_t is used everywhere, but only the FS layer
should _create_ lock tokens.

> My only worry is that maybe someday, svn_generate_locktoken() will
> want to use fs-specific stuff, such as the repos UUID, to generate
> tokens. Then we'd be in the situation of libsvn_subr "depending on"
> libsvn_fs_* to grab the repos UUID. Circular dependency again.

Exactly. So what you do is, you add "gen_lock_token" to the FS vtable,
and let the FS backend take care of the details. This takes care of all
the issues, I think.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Dec 2 08:50:59 2004