Re: svn commit: r12093 - branches/locking/subversion/mod_dav_svn

sussman@tigris.org wrote:

>Author: sussman
>Date: Mon Nov 29 22:03:52 2004
>New Revision: 12093
>
>

>+ /* Generate a UUID. */
>+ /* ### perhaps this should be a func in libsvn_fs.so, shared by
>+ mod_dav_svn and both fs back-ends?? */
>+ apr_uuid_get (&uuid);
>+ apr_uuid_format (uuid_str, &uuid);
>+ token->uuid_str = uuid_str;
>+ dlock->locktoken = token;
>
>
I think it's pretty much obvious that lock all lock token management
function should live in libsvn_fs, not in mod_dav_svn. What we have here
is a layering violation.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Dec 1 03:40:16 2004