Re: Dumpstream version parsing API warts

Greg Hudson <ghudson@MIT.EDU> writes:
> > the version number of the format that it is actually outputting, not
> > whatever happens to be the highest version parseable by the subversion
> > version it was compiled against.
>
> Fair enough.
>
> But I still think we should only deprecate, not delete, the version
> symbol. If an app is erroneously using it, it's not really our place to
> make that app stop compiling in svn 1.2.

I think we should deprecate the current symbol, and add

   SVN_REPOS_DUMPFILE_FORMAT_VERSION_3
   SVN_REPOS_DUMPFILE_FORMAT_VERSION_2
   SVN_REPOS_DUMPFILE_FORMAT_VERSION_1

as Max suggests. Any program outputting dump format should label that
data with the *lowest* format version it is compatible with. In other
words, Max's suggestion to output SVN_REPOS_DUMPFILE_FORMAT_VERSION_2
where that is accurate, even though 3 is available, makes sense.

We can *also* implement Greg's suggestion:

> It might be better to make svn_repos_parse_dumpstream work on
> version 3 dumps as long as they don't use deltas. (It would blow
> out with an error as soon as it saw a delta.)

That idea is not mutually exclusive with any of what Max proposed,
AFAICT.

Does all this sound like a sensible course?

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Nov 29 22:43:09 2004