[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: EBCDIC - was: (svn commit: r12029 - trunk/subversion/libsvn_client)

From: Branko ╚ibej <brane_at_xbc.nu>
Date: 2004-11-27 23:34:49 CET

Mark Phippard wrote:

>I assume when we run into ASCII "assumptions" we can somewhat
>treat it like an opportunity where we can improve the code for all
>platforms?
>
Oh yes.

>If the assumption is a safe one on an ASCII platform, I assume
>we should condition any UTF-8 to locale conversions so as to not add any
>extra performance overhead for ASCII platforms?
>
>
Well, that kind of logic can be hidden behind the API. For an example,
look at how we handle UTF-8-to-APR encoding on the Windows NT family,
where APR already expects filenames to be in UTF-8 and does its own
conversion, so _our_ conversion functions become noops.

>>Yes, you noticed that SVN sometimes converts string literals to UTF-8
>>itself, and sometimes it doesn't. This is the real problem, and I don't
>>know how to solve it (portably) without converting _every_ literal,
>>which would be a bit of a pain. Of course it would be nice if SVN could
>>expect every literal to be in UTF-8 (we really only care about the ASCII
>>subset anyway).
>>
>>
>The #pragma approach on OS/400 at least makes it manageable.
>
>

Yes, but the problem is that you have to conditionalize those pragmas in
the code itself. Is there a way to set that option on the command line?
Also, I'd like to see a solution that doesn't depend on an
OS/400-specific "apr-wrap.h" header. Instead, you could create
wrapper/forwarding headers for all of APR, and adjust the include paths.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Nov 27 23:35:41 2004

This is an archived mail posted to the Subversion Dev mailing list.